variable naming question

[jcome]

According to wiki.synfig.org/wiki/Dev:Coding_ … ions#Names

Names

File names: Filenames should be all lowercase and can include underscores (_). Some further rules may be defined for specific file types (icons, helper files, etc.).
Type names: Type names start with a capital letter and have a capital letter for each new word, with no underscores.
Variable names: Variable names are all lowercase, with underscores between words. Class member variables have trailing underscores.
Function names: --define me–
Enumerators names: Use capital letters and always use a prefix to identify them all.

I joined play and pause buttons as following,

Gtk::Image *icon1 = manage(new Gtk::Image(Gtk::StockID("synfig-animate_play"), Gtk::ICON_SIZE_BUTTON));
        play_pausebutton = manage(new class Gtk::Button());
        play_pausebutton->set_tooltip_text(_("Play"));

play_pause is already used in other piece of the preview.cpp, now my question is which one should I use in this case?
play_pause_button or play_pausebutton or playpausebutton ?

[Genete]

play_pause is already used in other piece of the preview.cpp, now my question is which one should I use in this case?
play_pause_button or play_pausebutton or playpausebutton ?

My suggestion is:
‘canvas_play_pause’ for the navigator framedial
‘preview_play_pause’ for the preview dialog

This way you don’t need to add the ‘button’ trailing tag.
-G

[jcome]

There is already a function named play_pause() in preview.cpp as bellow. I read canvas.cpp and found there are some similar variables using names xxxbutton, stopbutton for instance.

void studio::Widget_Preview::[b]play_pause/b
{
playing = false;
signal_pause()();
if(audio) audio->stop(); //!< stop the audio
//synfig::info(“Stopping…”);

    Gtk::Image *icon;
    icon = manage(new Gtk::Image(Gtk::StockID("synfig-animate_play"), Gtk::ICON_SIZE_BUTTON));
    [b]play_pausebutton[/b]->remove();
    [b]play_pausebutton[/b]->add(*icon);
    [b]play_pausebutton[/b]->set_tooltip_text(_("Play"));
    icon->set_padding(0,0);
    icon->show();

}

[Genete]

Maybe those variable names were given before those coding rules. There are lots of places where the naming is not followed. Please use the one you consider right and feel free to change naming on existing places if they deserve to be adapted to new coding naming scheme.
Coding conventions are only for readability and maintenance but the important thing is the functionality of the code.
-G