[GSoC 2020] Skeleton Tool

rodolforg · June 12, 2020, 6:21am

you can call it handle. I just said that in case you didn’t know what to search

KonstantinDmitriev · June 13, 2020, 6:27am

You can search source code and find where DUCK_COLOR_SELECTED string is used. This will be a starting point - just look there how code draws red box around handle (duck).

KonstantinDmitriev · June 13, 2020, 6:55am

I suggest to look at code of Draw Tool - it turns off some handles when activated. By looking at its code you can learn how to activate handles.

Here:

github.com

synfig/synfig/blob/48ac6ffa41b74e649f6208b0004005a1e0987830/synfig-studio/src/gui/states/state_draw.cpp#L940-L942


      
          	// Hide all tangent and width ducks
          	get_work_area()->set_type_mask(get_work_area()->get_type_mask()-Duck::TYPE_TANGENT-Duck::TYPE_WIDTH);
          	get_canvas_view()->toggle_duck_mask(Duck::TYPE_NONE);

and also line 964 is important -

github.com

synfig/synfig/blob/48ac6ffa41b74e649f6208b0004005a1e0987830/synfig-studio/src/gui/states/state_draw.cpp#L960-L965


      
          	get_work_area()->set_cursor(Gdk::PENCIL);
          
          	App::dock_toolbox->refresh();
          
          	refresh_ducks();
          }

DestinyGamer243 · June 14, 2020, 3:07pm

Weekly report : June 7th - June 14th

How was the last week? What did you accomplish?
- Implemented click on empty area to add skeleton layer.
- Implemented click to active bone.
- Implemented click or click-drag to add child bone to the active Bone. (Needs origin fixing)
- Exploring ways to highlight Active bone.
What is the #1 thing slowing you down?
- Finding a way to highlight the active bone.
What do you want to have done by the end of next week?
- Finish highlighting active bone.
- Filling all the remaining cases in this click functionality.

DestinyGamer243 · June 19, 2020, 1:18pm

Hey!

I wanted to do something like this. So I’ve been reading Layer_shape and it’s generate_render_task to check if I can modify the color for just one bone. But I could not figure it out. Any hint would be helpful!

KonstantinDmitriev · June 20, 2020, 1:18pm

I’ve got an impression that this approach is too much low-level.

I was expecting that you will make this on UI-level, like this -

There is already a highlighting function for spline points. Why not to use it for bones in the same way?

rodolforg · June 21, 2020, 4:04am

I don’t think it’s intuitive and user friendly as @DestinyGamer243 proposal.
Besides, don’t the red squares represent linking?

DestinyGamer243 · June 21, 2020, 7:23am

Also, I’ve been trying to fix the origin issue. I don’t know why but I am unable to get it work right.

There is no global origin parameter for a bone too. So I tried translating axes according to the parent origin. But couldn’t get results. What do you think? :?

KonstantinDmitriev · June 21, 2020, 1:29pm

The problem with @DestinyGamer243’s proposal is that bone is highlighted through rendering engine (very slow and low-level operation). I think that highlighting a bone should be done using UI elements, not rendering.

BTW, highlighting a bone is already implemented -

I am okay if that will be highlighted in some other way, but this should be done through UI (workarea), not through rendering engine.

I suggest to take a look at duckmatic.cpp to see how bone is highlighted.

No, it represents selection.

DestinyGamer243 · June 21, 2020, 3:24pm

Weekly report : June 14th - June 21th

How was the last week? What did you accomplish?
- Closed edge cases in the click action
- Explored ways to highlight bones according to my approach (Which proved to be very low level)
- Explored ways to fix origin issue (Couldn’t find it out, tried one but it didn’t work out well).
What is the #1 thing slowing you down?
- Origin fix.
What do you want to have done by the end of next week?
- Finishing the click and double-click functionality .

rodolforg · June 21, 2020, 4:48pm

indeed. But he achieves to highlight active bone as he proposed in UI elements, it’d be great IMHO

Oh

KonstantinDmitriev · June 22, 2020, 3:18am

I suggest to look at the code of circle tool for reference.

KonstantinDmitriev · June 22, 2020, 3:21am

I also think that eventually we should rework bones to make them drawn purely in UI. There are actually no need to have their drawing routines in render engine.

KonstantinDmitriev · June 22, 2020, 3:23am

If I remember correctly, bone origin is always absolute. It is not relative to its parent.

KonstantinDmitriev · June 22, 2020, 5:45am

Oh, no, I am wrong.

KonstantinDmitriev · June 22, 2020, 7:25am

@DestinyGamer243 Please push your latest code to this PR - https://github.com/synfig/synfig/pull/1485
If it doesn’t compile, then put appropriate remark in commit message.

DestinyGamer243 · June 22, 2020, 7:27am

Yes on it. I kinda overslept sorryy!

DestinyGamer243 · June 28, 2020, 4:06pm

Weekly report : June 21th - June 28th

How was the last week? What did you accomplish?
- Finished “Click to active bone”
- Highlighting active bone
- Click and draw is almost done. It’s working fine.
What is the #1 thing slowing you down?
- If I’d have come accross animated_matrix_ earlier, the origin fix would have been done very early. Thank you @KonstantinDmitriev on this!
What do you want to have done by the end of next week?
- Start working on the popup_param_menu

DestinyGamer243 · July 5, 2020, 7:18pm

Weekly report : June 29th - July 5th

How was the last week? What did you accomplish?
- Active Bone rendering separated and fixed.
- Origin issue fixed.
- Added valuedescmakeparenttoactive and added it to the context menu of bones.
- Working on fixing the bone detection and making bone draw undoable. (Needs work)
What is the #1 thing slowing you down?
- Making the action undoable. More specifically, active bone choices.
What do you want to have done by the end of next week?
- Fix the Bone detection.
- Make the skeleton tool draw undoable.
- Maybe complete the valuedescmakeparenttoactive action

DestinyGamer243 · July 12, 2020, 3:59pm

Weekly report : July 6th - July 12th

How was the last week? What did you accomplish?
- Undo system working!
- Modified tool options menu.
- Basic implementation of “Make Parent to Active Bone” done.
- Fixed bone detection.
- Added support to “Skeleton Deformation Layer”.
What is the #1 thing slowing you down?
- Adding a preview bone while dragging. Working on it!
What do you want to have done by the end of next week?
- Finish, “Make parent to active bone”.
- Add a preview bone while dragging.