[GSoC 2020] Skeleton Tool

[DestinyGamer243]

@KonstantinDmitriev

You can start with a first step:
Just create an empty skeleton layer when user clicks on empty space.

Yes!

@KonstantinDmitriev

Active bone is defined by clicking on any bone. If user haven’t clicked on any bone, then there are no active bone. That means that new created bone will have no parent .

Oh! Alrighty! Will do!

[DestinyGamer243]

Hey!

Is there a way to check if the current selected layer is a Skeleton layer?

The tool will add bone to the selected layer if it’s a skeleton layer. If it’s not a skeleton type, it’ll just add a new skeleton layer with bone accordingly.

I’m thinking to add active bone as a parameter to the skeleton layer. I think it’ll work well. As multiple layers will have their own active bone and just by selecting them, we can show the bone highlighted accordingly. What say?

[rodolforg]

@DestinyGamer243

Is there a way to check if the current selected layer is a Skeleton layer?

Yes. The current selected layer(s) (yes, plural) are available via synfigapp::SelectionManager . You can get this object via synfigapp::CanvasInterface::get_selection_manager().

You can check if a layer is of your desired type in two different way (at least):

• the Layer type name (Layer::get_name()), or
• C++ RTTI, ie., dynamic typecasting (etl::handle<[YourLayerClass]>::cast_dynamic([YourLayerObjectHandle]) if it’s a handle) : check if it doesn’t return nullptr and there you have it

[DestinyGamer243]

@rodolforg

the Layer type name ( Layer::get_name() ),

This is returning the user set name of the layer.

@rodolforg

etl::handle<[YourLayerClass]>::cast_dynamic([YourLayerObjectHandle]

Will try this! Thanks!

[rodolforg]

@DestinyGamer243

This is returning the user set name of the layer.

No, it’s not The label user assign to a label is called layer description, actually Layer::get_description()

[rodolforg]

@DestinyGamer243

The tool will add bone to the selected layer if it’s a skeleton layer. If it’s not a skeleton type, it’ll just add a new skeleton layer with bone accordingly.

Nice Don’t forget to do such things via synfigapp actions. Otherwise undo/redo won’t work.

@DestinyGamer243

I’m thinking to add active bone as a parameter to the skeleton layer.

I don’t think it’s the best way, as it is only useful for Synfig Studio, not rendering.

On the other hand, group layer already has such feature: lock children selection.

Anyway, you can do it if it helps you now at the beginning.

[DestinyGamer243]

@rodolforg

No, it’s not The label user assign to a label is called layer description, actually Layer::get_description()

Ohhh!! Cool! I’ll check it out!

@rodolforg

Don’t forget to do such things via synfigapp actions. Otherwise undo/redo won’t work.

yep!

@rodolforg

On the other hand, group layer already has such feature: lock children selection.

Oh! Will check it out!

@rodolforg

Anyway, you can do it if it helps you now at the beginning.

Will try to not include it!

[rodolforg]

@rodolforg

group layer already has such feature: lock children selection

Rewording: group layer already has a parameter useless for rendering, just for editing in Studio.
Sorry my english XD

[DestinyGamer243]

Weekly report : June 1st - June 7th

• How was the last week? What did you accomplish?

  • Explored the action systems and docks.
  • Understood the code related to the ducks, layer_Skeleton, and Bone classes.
  • Started working on click to add bone with/without layer_Skeleton.

• What is the #1 thing slowing you down?

  • Couldn’t find proper documentation for some classes.

• What do you want to have done by the end of next week?

  • Finish the click to add bone functionality.

Not much work done as I had to work on some assignments deadlines. I will try to balance it with next week.

[KonstantinDmitriev]

@rodolforg

I don’t think it’s the best way, as it is only useful for Synfig Studio, not rendering.

Yes, I agree about that.

I think there is no need to remember active bone in every layer.

I expect following workflow if user wants to modify existing Skeleton layer with Skeleton Tool:

• User selects existing Skeleton Layer
• User choosing Skeleton Tool (Actually, he can do that earlier ^__^)
• Skeleton Layer has no active bone. Two possibilities:
• 1. If user wants to indicate some bone as active, then he clicks that bone → it becomes active. User creates new bone and this new bone becomes child for active bone. After that newly created bone automatically marked as active.
• 2. User not selects any bone → no active bone. User creates a new bone and this new bone has no parent (because there were no active bone during creation). After that newly created bone automatically marked as active.

[DestinyGamer243]

If no skeleton layer is chose, then we’ll add a new layer and add a bone with origin at the click, right?

@KonstantinDmitriev

User not selects any bone → no active bone. User creates a new bone and this new bone has no parent

Alright. Will work in that direction.

[KonstantinDmitriev]

@DestinyGamer243

If no skeleton layer is chose, then we’ll add a new layer and add a bone with origin at the click, right?

Yes, exactly!
And after that the new Skeleton layer becomes selected. And added bone becomes active bone.

[DestinyGamer243]

Cool!
I’ve tried to use the ValueDescCreateChildBone to add child bone to the active bone. But it seems that the canvas is not set. How can I do that?

[KonstantinDmitriev]

You can get canvas from layer.

[DestinyGamer243]

How are we calling Non-static functions here? (sorry if it’s a silly doubt)

Here:

synfig/synfig/blob/7ab41fa0a9bfdcddaecb579e4cf84eafe9e3e803/synfig-studio/src/synfigapp/actions/valuedesccreatechildbone.cpp#L121

[rodolforg]

The code is an implamentation of a method of a class ( Action::ValueDescCreateChildBone) that is derived from Action::CanvasSpecific.
That highlighted line is not a static method call: it’s just saying to call the “parent” (Action::CanvasSpecific) implementation of set_param() using current (and compatible, as it’s a derived one) object (I mean the this).

[DestinyGamer243]

Ohh cool! Figured that immediately but forgot to delete it here. So silly of me

I made a new commit.

• Added find_bone to find bones near click.
• Set active bone
• Adding a child bone to the active bone on click is working, but the origin of the child bone still needs fixing.

@KonstantinDmitriev

Synfig already can highlight points of spline, when some its vertex selected in Params panel -

Actually, I want to change the color of the contour of the active bone. Can you suggest me the file I’ll have to refer to? Also, how do I enable handles when using this tool?

[KonstantinDmitriev]

@DestinyGamer243

Actually, I want to change the color of the contour of the active bone. Can you suggest me the file I’ll have to refer to?

Please check this -

synfig/synfig/blob/7684be864f20b5cda39dd07833e74e78a874e6d3/synfig-studio/src/gui/workarearenderer/renderer_ducks.h#L70-L71

@DestinyGamer243

Also, how do I enable handles when using this tool?

I am not sure what do you mean. Can you please clarify? ^__^"

[rodolforg]

@DestinyGamer243

Also, how do I enable handles when using this tool

Do you want to create new handles or reuse an existent one?
I can’t help you much, but “handle” is called “duck” in the code.

[DestinyGamer243]

@KonstantinDmitriev

I am not sure what do you mean. Can you please clarify? ^__^"

@rodolforg

I can’t help you much, but “handle” is called “duck” in the code.

Sorry! I meant the ducks of the bones.

@KonstantinDmitriev

Please check this -

Okay! I already did! Maybe I missed something will do!