# \[Windows - Request for Test\] Open Infinite Error Windows from Eyedropper #3288

**URL:** <https://forums.synfig.org/t/windows-request-for-test-open-infinite-error-windows-from-eyedropper-3288/15123>\
**Category:** Debugging\
**Tags:** windows, debug\
**Created:** [June 11, 2024, 4:14pm UTC](https://forums.synfig.org/t/windows-request-for-test-open-infinite-error-windows-from-eyedropper-3288/15123 "2024-06-11T16:14:55Z")\
**Posts on this page:** 14\
**Page:** 1

<div class="post-metadata">

**Author:** ![BobSynfig](https://forums.synfig.org/user_avatar/forums.synfig.org/bobsynfig/32/175_2.png) [@BobSynfig](https://forums.synfig.org/u/BobSynfig)\
**Post date:** [June 11, 2024, 4:14pm UTC](https://forums.synfig.org/t/windows-request-for-test-open-infinite-error-windows-from-eyedropper-3288/15123/1 "2024-06-11T16:14:55Z")

</div>

Dear (windows) friends,

would you please test the fixed behavior described in the issue with the dev build  
[https://ci.appveyor.com/api/buildjobs/cctv7pxaq7ijd23t/artifacts/SynfigStudio-1.5.2-testing-2024-06-09-win64-7cfc0.zip](https://ci.appveyor.com/api/buildjobs/cctv7pxaq7ijd23t/artifacts/SynfigStudio-1.5.2-testing-2024-06-09-win64-7cfc0.zip) (link expires July 9)

and report for have confirmation that it works fine for you.

The user on GitHub who originally reported doesn’t show a lot of activity and we may be waiting for long before his answer 😛

Thanks to you in advance and to @rodolforg for his dedication for improve our favorite software 🙂

> [@rodolforg](#):
>
> Please note that is a dev. version. Do not save your projects from 1.4.x versions with it without a proper backup.

> <https://github.com/synfig/synfig/issues/3288>
>
> \*\*Describe the bug\*\*
> When attempting to use the eyedropper, I go the error "Una…ble to set all layer parameters," but the eyedropper is apparently still active. Attempting to close the error window results in the eyedropper trying to pick the color of the error box and spawned new error windows for every click. The escape and enter key all seem to also select colors and spawn new errors instead of letting me exit. I can't close the window from my taskbar, so I either have to use task manager or wait for it to crash. Recovery saved my work, so no big issues there.
> 
> Cause of Error: I opened the color picker then realized the color I wanted was on the bottom layer and covered. I moved that layer while the color picker was open, then attempted to sample from it. The correct color was chosen before the error occurred. On my second attempt, the same error did not happen.
> 
> My layers were an advanced outline, a region, and a png (in that order from top to bottom). Then I moved the png to the top layer. There is an error that occurs before "Unable to set all layer parameters," but it is covered too fast for me to easily read it.
> 
> \*\*To Reproduce\*\*
> Steps to reproduce the behavior:
> 1. Go to Parameters (for a region)
> 2. Click on the color box next to the Color parameter to open the selector
> 3. Move the bitmap layer to the top
> 4. Attempt to select a color from bitmap image
> 5. See error
> 
> \*\*Expected behavior\*\*
> The color is selected, or the resulting error can be exited.
> 
> \*\*Screenshots\*\*
> !\[image\](https://github.com/synfig/synfig/assets/152563065/7fe8f6ed-a733-4f0c-9ef2-23b074f667f9)
> 
> \*\*System information:\*\*
> - OS: Windows 10
> - OS version: 10.0.19045 Build 19045
> - Synfig version: 1.4.2
> 
> \*\*Additional comments\*\*
> I was able to reproduce it consistently. This only occurs when I move and sample from a bitmap image, not a region or outline.

---

<div class="post-metadata">

**Author:** ![Svarov](https://forums.synfig.org/user_avatar/forums.synfig.org/svarov/32/8167_2.png) [@Svarov](https://forums.synfig.org/u/Svarov)\
**Post date:** [June 12, 2024, 5:04am UTC](https://forums.synfig.org/t/windows-request-for-test-open-infinite-error-windows-from-eyedropper-3288/15123/2 "2024-06-12T05:04:38Z")

</div>

I can’t reproduce the described bug with the linked test build.  
After moving the bitmap layer, color dialog still applies changes to the previously selected region layer unlike in 1.4.4.

I even tried to delete the region layer after color dialog was open and still no error messages, it just silently ignored the fact that layer was deleted. So I guess bug is resolved.

---

<div class="post-metadata">

**Author:** ![rodolforg](https://forums.synfig.org/letter_avatar_proxy/v4/letter/r/c68b51/32.png) [@rodolforg](https://forums.synfig.org/u/rodolforg)\
**Post date:** [June 12, 2024, 9:32am UTC](https://forums.synfig.org/t/windows-request-for-test-open-infinite-error-windows-from-eyedropper-3288/15123/3 "2024-06-12T09:32:24Z")

</div>

> [@Svarov](#):
>
> I even tried to delete the region layer after color dialog was open and still no error messages

And if you edit color after layer deletion? Any error is raised?

---

<div class="post-metadata">

**Author:** ![Svarov](https://forums.synfig.org/user_avatar/forums.synfig.org/svarov/32/8167_2.png) [@Svarov](https://forums.synfig.org/u/Svarov)\
**Post date:** [June 12, 2024, 10:14am UTC](https://forums.synfig.org/t/windows-request-for-test-open-infinite-error-windows-from-eyedropper-3288/15123/4 "2024-06-12T10:14:25Z")

</div>

> [@rodolforg](#):
>
> And if you edit color after layer deletion? Any error is raised?

Nope, nothing. It functions as if the layer was still there and when you click “Close”, the dialog window closes as normal without affecting anything.

---

<div class="post-metadata">

**Author:** ![rodolforg](https://forums.synfig.org/letter_avatar_proxy/v4/letter/r/c68b51/32.png) [@rodolforg](https://forums.synfig.org/u/rodolforg)\
**Post date:** [June 13, 2024, 12:13am UTC](https://forums.synfig.org/t/windows-request-for-test-open-infinite-error-windows-from-eyedropper-3288/15123/5 "2024-06-13T00:13:03Z")

</div>

Ugh.  
I got an error.  
If user deletes the layer, s/he can use the dialog without problems (pointless, but no problem) Except if s/he tries to undo. Then inocuous undo happens

---

<div class="post-metadata">

**Author:** ![Svarov](https://forums.synfig.org/user_avatar/forums.synfig.org/svarov/32/8167_2.png) [@Svarov](https://forums.synfig.org/u/Svarov)\
**Post date:** [June 13, 2024, 6:13pm UTC](https://forums.synfig.org/t/windows-request-for-test-open-infinite-error-windows-from-eyedropper-3288/15123/6 "2024-06-13T18:13:29Z")

</div>

> [@rodolforg](#):
>
> Then inocuous undo happens

You mean that undo history gets polluted with color choices and user can no longer undo layer delete operation?

Well, it’s what we get for letting user communicate with the main window while upper dialog window is still opened. I always wondered why Synfig doesn’t block interaction with the main window until the color (or any other important dialog window) is opened.

---

<div class="post-metadata">

**Author:** ![mohamed.Adhamc](https://forums.synfig.org/letter_avatar_proxy/v4/letter/m/a88e4f/32.png) [@mohamed.Adhamc](https://forums.synfig.org/u/mohamed.Adhamc)\
**Post date:** [June 13, 2024, 6:25pm UTC](https://forums.synfig.org/t/windows-request-for-test-open-infinite-error-windows-from-eyedropper-3288/15123/7 "2024-06-13T18:25:59Z")

</div>

> [@Svarov](#):
>
> Well, it’s what we get for letting user communicate with the main window while upper dialog window is still opened. I always wondered why Synfig doesn’t block interaction with the main window until the color (or any other important dialog window) is opened.

Well I suppose if there are no use-cases that require the color dialog not be “modal” (freezes the other parts of the program). The this should be quite easy to do.

---

<div class="post-metadata">

**Author:** ![BobSynfig](https://forums.synfig.org/user_avatar/forums.synfig.org/bobsynfig/32/175_2.png) [@BobSynfig](https://forums.synfig.org/u/BobSynfig)\
**Post date:** [June 14, 2024, 2:50pm UTC](https://forums.synfig.org/t/windows-request-for-test-open-infinite-error-windows-from-eyedropper-3288/15123/8 "2024-06-14T14:50:13Z")

</div>

> [@mohamed.Adhamc](#):
>
> Well I suppose if there are no use-cases that require the color dialog not be “modal” (freezes the other parts of the program). The this should be quite easy to do.

There is at least a use case 😛  
When selecting foreground/background color it doesn’t matter (and it is stopped).  
But when you change the color from the properties, you can see in live preview the changes on the canvas 😉

![Peek 2024-06-14 17-48](https://forums.synfig.org/uploads/default/original/2X/7/79a432b3a7776aea4431789f8bec2bdcf5843a82.gif)

---

<div class="post-metadata">

**Author:** ![mohamed.Adhamc](https://forums.synfig.org/letter_avatar_proxy/v4/letter/m/a88e4f/32.png) [@mohamed.Adhamc](https://forums.synfig.org/u/mohamed.Adhamc)\
**Post date:** [June 14, 2024, 4:55pm UTC](https://forums.synfig.org/t/windows-request-for-test-open-infinite-error-windows-from-eyedropper-3288/15123/9 "2024-06-14T16:55:23Z")

</div>

> when you change the color from the properties

Oh yes I do that a lot. I don’t know how I missed that xD.

---

<div class="post-metadata">

**Author:** ![Svarov](https://forums.synfig.org/user_avatar/forums.synfig.org/svarov/32/8167_2.png) [@Svarov](https://forums.synfig.org/u/Svarov)\
**Post date:** [June 14, 2024, 6:08pm UTC](https://forums.synfig.org/t/windows-request-for-test-open-infinite-error-windows-from-eyedropper-3288/15123/10 "2024-06-14T18:08:23Z")

</div>

> [@BobSynfig](#):
>
> But when you change the color from the properties, you can see in live preview the changes on the canvas

I wasn’t thinking about “completely freezing” the rest of the program, that would be of course bad. My idea was to disable the user input for the canvas window. It would still refresh and accept changes from dialog but won’t accept mouse clicks and key pressed until user closes the top dialog window.

---

<div class="post-metadata">

**Author:** ![BobSynfig](https://forums.synfig.org/user_avatar/forums.synfig.org/bobsynfig/32/175_2.png) [@BobSynfig](https://forums.synfig.org/u/BobSynfig)\
**Post date:** [June 14, 2024, 7:06pm UTC](https://forums.synfig.org/t/windows-request-for-test-open-infinite-error-windows-from-eyedropper-3288/15123/11 "2024-06-14T19:06:35Z")

</div>

I think that the idea was to be able to change the color of different layers at the same time, without to close and reopen selecting the color property:  
Just change of layer and go to the color field of the dialog then press _Enter_, the 2 layers are the same color now.  
You can of course change of color using a [standard name like lavender, silver, pink](https://en.wikipedia.org/wiki/X11_color_names) …

It speeds the workflow, the only annoying part is the logging of action of change of color … which can be “muted” as when we simply assign a color as fore/background color in the Toolbox

![Peek 2024-06-14 22-01](https://forums.synfig.org/uploads/default/original/2X/6/630e4d6084ed26d2c302fcdaaad7a5c4f88fab30.gif)

---

<div class="post-metadata">

**Author:** ![rodolforg](https://forums.synfig.org/letter_avatar_proxy/v4/letter/r/c68b51/32.png) [@rodolforg](https://forums.synfig.org/u/rodolforg)\
**Post date:** [June 14, 2024, 10:09pm UTC](https://forums.synfig.org/t/windows-request-for-test-open-infinite-error-windows-from-eyedropper-3288/15123/12 "2024-06-14T22:09:29Z")

</div>

> [@BobSynfig](#):
>
> I think that the idea was to be able to change the color of different layers at the same time

We can do it by selecting multiple layers  
too =]

---

<div class="post-metadata">

**Author:** ![Svarov](https://forums.synfig.org/user_avatar/forums.synfig.org/svarov/32/8167_2.png) [@Svarov](https://forums.synfig.org/u/Svarov)\
**Post date:** [June 15, 2024, 4:29am UTC](https://forums.synfig.org/t/windows-request-for-test-open-infinite-error-windows-from-eyedropper-3288/15123/13 "2024-06-15T04:29:06Z")

</div>

> [@BobSynfig](#):
>
> I think that the idea was to be able to change the color of different layers at the same time, without to close and reopen selecting the color property:

So we no longer discussing the bug but rather if the old behavior was intentional? I never used it myself, was always changing color of multiple layers by selecting them first and then opening color dialog (like rodolforg mentioned).

I can see that if you want to set **different colors** on **a lot** of different layers, then this functionality would be useful but I can’t think of a practical example for that.

---

<div class="post-metadata">

**Author:** ![rodolforg](https://forums.synfig.org/letter_avatar_proxy/v4/letter/r/c68b51/32.png) [@rodolforg](https://forums.synfig.org/u/rodolforg)\
**Post date:** [June 15, 2024, 4:06pm UTC](https://forums.synfig.org/t/windows-request-for-test-open-infinite-error-windows-from-eyedropper-3288/15123/14 "2024-06-15T16:06:36Z")

</div>

I can make it not react to pollute the undo action history if the layer is deleted.

But I think it would be better if it closes automatically if that happens to the layer. However, I’m struggling to do it in an ‘elegant’ way, and keep stuff independent.
