What about modernizing Synfig code

[rodolforg]

@rodolforg

Related to code simplification, we could start by ETL:

• replace smart_ptr
• remove useless etl_config.h
• don’t separate its files in without/with .h: I can’t see why it’s this way now
• move away to synfig-core non-template stuff, like angle, clock, misc and stringf
• split stringf: filepath related stuff should not be there
• compare misc’s binary_find vs. std::binary_search and do something about it
• cry and whine about handle and reference_count
• move everything else to synfig-core

Current status:

• replace smart_ptr (#2686)
• remove useless etl_config.h (#2733)
• don’t separate its files in without/with .h: I can’t see why it’s this way now
• move away to synfig-core non-template stuff, like angle (#2715), clock (#2711), misc and stringf (WIP: #2735)
• split stringf: filepath related stuff should not be there (WIP: #2710)
• compare misc’s binary_find() vs. std::binary_search() (or std::lower_bound()) and do something about it
• cry and whine about handle and reference_count
• move everything else to synfig-core

Regarding Trying to define our Code Style, I already wrote a doc summarizing and exemplifying the voted style. I’m coding trying to follow it and checking some stuff. (Example: I missed to ask the style for single-line doc comment ).