How is the development going on?
I’m standing by with the icon design of my Modern iconset (light and dark) as all the icons remaining are those that are “hard coded” and dependent of the “adwaita-legacy” iconset.
In case you don’t remember the conversation, in the next screenshot you have a bunch of icons that aren’t themeable as they are “hard coded”:
And following the actual status of icon development:
So in the red box you see the list of icons that are not themeable, the ones that have the icon visible is because I have already created a SIF format version of it so that it can be added to the default Synfig iconset but, more important, with your code changes it can turn into a themeable icon and I would be able to create a SVG with the modern icon and finally publish it into PNG. (I guess in the future you will add SVG support and it will make things easier).
So, my question is: what is the status of the development and when could you partner me with this subject and turn the whole Synfig iconset themeable?
I’ve seen only one of two PR have been merged but I’m unsure if you need them all to be merged or we can continue the development.
PS - in case you feel like starting to tinker here is an example:
edit_delete.sif (138,9 KB)
Please try to use gtk-revert-to-saved-ltr.png and gtk-revert-to-saved-rtl.png in your icon theme to check if it works for now.
Whoops. For this icon, gtk-delete.png
I have tried adding a png with that name, that is,
gtk-delete.png in the icons folder and it didn’t work…
I guess you meant to add entries in
iconcontroller.cpp with that name, right?
Sorry. It should be
it worked out of the box by just adding a
edit-delete.png icon into the icons folder.
What about the rest of icons I reported weren’t working? is there a pattern I can follow in order to find the name I should use in order to make it “themeable”?
I was able to locate all or most of them: the only ones that I can’t locate are the following ones but I suspect they are or hard-coded or part of the system, please, could you confirm it?
Anyway, you gave me the key to accomplish the very first whole icon replacement and set the foundation for new ones to come
The plus/minus signs to increase/decrease the brush size currently are just a text label inside a button.
The check mark in Parameters Panel and the checkboxes in the menus are drawn directly Gtk “framework”. I know how to change the parameter case, but not the one of menu items.
So, my suspects were right, thanks.
I will then finish the icon theme and release it.
We can change the buttons of brush size to use icons not text.
We can change the parameters panel check mark to an icon too.
If you provide icons to the current (not well) defined theme…
Not too related but I have to say I am excited to see these icons eventually (hopefully) being used : ).
Yes, that’s it!
As I think you used default “plus” and “minus” icons, I would highly suggest to duplicate these icons and use new names so that they can be themed independently of regular “plus” and “minus” ones.
Would that make sense to you and do you agree?
Well, I think we can close the poll choosing:
I have almost finished the icons but, meanwhile, I found these 3 ones that haven’t been themed and I don’t know if they can be: inside Options panel:
Are “Apply”, “Cancel” and “OK” icons themeable?
EDIT - resize screenshot as it was too big…
maybe gtk-apply, gtk-cancel and gtk-ok
The theme it’s almost finished
Using Synfig in a personal project found these icons that haven’t been added to my “modern icon theme”. I was digging into the code and the useful links you gave me about Adwaita old icons but none works… any idea on what are their names and if they are “themeable”?:
EDIT - highlighted a wrong icon
Would they be gtk-convert, gtk-disconnect, gtk-yes, gtk-no, gtk-connect?